matrix-org / matrix-org/matrix-bifrost
Stanza attribute escaping looks like a foot gun
Open
Nobody has claimed this yet.
T-Defect
- Dominant language
- TypeScript
- Stars
- 187
- Forks
- 38
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/matrix-org/matrix-bifrost/blob/f2f28bb7f7b069b8491c822e54ad0eeab6d8d114/src/xmppjs/Stanzas.ts#L23-L27
This, escaping fields in a setter instead of during serialization, scares me.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading src/xmppjs/Stanzas.ts around lines 23-27 and trace how stanza attributes are set and serialized. Determine how escaping should be handled without creating surprising setter behavior, then verify the resulting stanza output with the relevant existing checks, if any.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100