matrix-org / matrix-org/matrix-bifrost

Wrong membership sent to XMPP joiners when using pre-cached member list

Open
#157 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

S-Critical T-Defect
Dominant language
TypeScript
Stars
187
Forks
38
PR merge metrics
No merged PRs in 30d

Description

This is serious and wrong. A quick fix was to refresh the cache on each join, but we shouldn't need to!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the XMPP join flow and how the pre-cached member list is read when a joiner connects. Reproduce the incorrect membership, compare it with the refresh-on-each-join workaround, and verify that joins use current membership without requiring a full cache refresh.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.