matrix-org / matrix-org/gomatrixserverlib

LookupWellKnown doesn't specify user agent

Open
#253 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

T-Task
Dominant language
Go
Stars
67
Forks
60
PR merge metrics
No merged PRs in 30d

Description

### Background information

- **Dendrite version or git SHA**: v0.3.5
- **Monolith or Polylith?**: Monolith
- **SQLite3 or Postgres?**: postgres
- **Running in Docker?**: no
- **`go version`**: go1.15.2 linux/amd64

### Description

Right now, Dendrite identifies itself with the User-Agent string `Go-http-client/2.0`. This should be something like `Dendrite/0.3.5`, just as Synapse does.

### Steps to reproduce

- Tail your web server access logs for `/.well-known/matrix/server`
- Dendrite identifies itself as `Go-http-client/2.0`
- Synapse identifies itself as `Synapse/1.24.0`

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the LookupWellKnown entry point and reproduce the request to /.well-known/matrix/server while observing the outgoing User-Agent. Done means the request identifies itself as Dendrite with its version rather than Go-http-client/2.0; check nearby tests or add coverage if the existing test layout supports it.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.