matrix-org / matrix-org/eigen-server

Not checking for integers correctly

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug i-d:03 rver:IDMimiLinearized00 rver:IDMimiLinearized02
Dominant language
TypeScript
Stars
9
Forks
1
PR merge metrics
No merged PRs in 30d

Description

We're supposed to be limited by what Canonical JSON can handle, but in practice we're just using `Number.isInteger()` in JS, which means a whole lot more is possible.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names Number.isInteger() and Canonical JSON but does not identify a file, test, or entry point. Locate the integer-validation path, read the project’s Canonical JSON constraints, and add coverage showing that validation follows those constraints rather than JavaScript’s broader Number.isInteger() behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.