matrix-org / matrix-org/complement
`TestRoomCreationReportsEventsToMyself` tests unspecified behaviour
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 99
- Forks
- 72
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 8
Description
https://github.com/matrix-org/complement/blob/1a2baac5dbf45ead46409793fe625b3c253eb4f6/tests/csapi/rooms_state_test.go#L90-L108
This behaviour is not written anywhere in the specification and is technically incorrect behaviour considering there is no transaction ID for setting state (which removes the idempotency guarantee)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at tests/csapi/rooms_state_test.go lines 90-108 and compare the assertion with the Matrix specification for setting state. Determine how the test should change so it no longer requires behavior that is unspecified and lacks a transaction ID; done when the suite no longer asserts that behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100