matrix-org / matrix-org/complement
Device deletion tests depend on oneshot UIA
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 99
- Forks
- 72
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 8
Description
Related: #893
https://github.com/matrix-org/complement/blob/1a2baac5dbf45ead46409793fe625b3c253eb4f6/tests/csapi/apidoc_device_management_test.go#L143-L153
https://github.com/matrix-org/complement/blob/1a2baac5dbf45ead46409793fe625b3c253eb4f6/tests/csapi/apidoc_device_management_test.go#L168-L178
https://github.com/matrix-org/complement/blob/1a2baac5dbf45ead46409793fe625b3c253eb4f6/tests/csapi/apidoc_device_management_test.go#L207-L217
https://github.com/matrix-org/complement/blob/1a2baac5dbf45ead46409793fe625b3c253eb4f6/tests/csapi/apidoc_device_management_test.go#L230-L240
Device management tests which delete devices depend on being able to skip UIA, which is not spec compliant and causes flaky failures.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the four referenced sections of tests/csapi/apidoc_device_management_test.go and compare their device-deletion setup with the context in related issue #893. Determine how the tests can exercise spec-compliant UIA rather than skipping it, then verify the device-management tests no longer rely on oneshot UIA or fail intermittently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100