matrix-org / matrix-org/complement
Password change tests depend on oneshot UIA
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 99
- Forks
- 72
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 8
Description
Related: #893
https://github.com/matrix-org/complement/blob/1a2baac5dbf45ead46409793fe625b3c253eb4f6/tests/csapi/account_change_password_test.go#L110-L122
The password change helper requires being capable of skipping UIA, which is not spec compliant and causes flaky failures in all tests that use it.
The test also depends on being able to do oneshot UIA as it does not use the helper: https://github.com/matrix-org/complement/blob/1a2baac5dbf45ead46409793fe625b3c253eb4f6/tests/csapi/account_change_password_test.go#L82-L95
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading tests/csapi/account_change_password_test.go at lines 82-95 and 110-122, then review related issue #893 and the password change helper they reference. Confirm how the tests currently skip or perform UIA, and make the password-change coverage use spec-compliant UIA handling without oneshot dependencies. Done means the affected tests no longer rely on those behaviors or fail intermittently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100