matrix-org / matrix-org/complement
Two key-upload-related tests being blacklisted by synapse
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 99
- Forks
- 72
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 8
Description
When I was looking over `SkipIf`s in the codebase, I found out that these following tests are explicitly blacklisted on synapse.
https://github.com/matrix-org/complement/blob/d5025cd75007609d52a77535388be9317963aedd/tests/csapi/upload_keys_test.go#L77
https://github.com/matrix-org/complement/blob/d5025cd75007609d52a77535388be9317963aedd/tests/csapi/upload_keys_test.go#L56
Seeing as how these tests are related to data validation on a server's side, I do not understand why Synapse wants to skip them, thus this issue as a nag; Why does Synapse skip these tests?
I want to update the comment with a reason given, or a reference to an issue/discussion about exactly that, or to an issue working towards clearing this skip.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the two SkipIf locations in tests/csapi/upload_keys_test.go, at the referenced lines, and inspect the surrounding comments and test behavior. Investigate Synapse's reason for blacklisting these key-upload validation tests, including any linked issue or discussion. Done means the skip comment explains the reason or points to the relevant discussion or issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing-qa
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100