matrix-org / matrix-org/complement
container logs not flushed if there is a timeout spinning up a container
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 99
- Forks
- 72
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 8
Description
#392 added a ContainerStop to Deployer.Destroy, so that the container has a chance to gracefully shut down and flush its logs before we print them.
However, we print the logs in a couple of other situations:
- in
Deployer.Deploy, if there is a timeout waiting for the container to be ready. (In this case it looks like we don't destroy the container at all?) - in
Builder.ConstructBlueprint(viaBuilder.construct).
In both these cases, the logs are printed before the container is stopped.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading Deployer.Deploy and Builder.ConstructBlueprint via Builder.construct, then compare their log handling with Deployer.Destroy and its ContainerStop behavior. Reproduce the timeout and construction paths to verify when logs are printed. Done means the container is stopped before logs are printed in both cases, with the timeout path also handling the container lifecycle correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100