matrix-org / matrix-org/complement-crypto
Allow dedicated client-specific tests
@kegsay is already working on this.
Since Sep 24, 2024.
- Dominant language
- Go
- Stars
- 18
- Forks
- 12
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 6
Description
The tooling in complement-crypto is useful enough that it's often easier to write end-to-end tests in it than client-specific integration tests (e.g rust SDK). Unfortunately, the current structure/design has worked hard to make the tests _agnostic_ to the underlying client implementation, but there is value in allowing tests to test client-specific things. We effectively already do this in places (e.g the notification tests which are very rust SDK focused), but we just kind of awkwardly add functions to the generic client interface.
Ideally, we should just let tests type-cast to a concrete impl. Considerations though:
- the impl may be behind an RPC barrier, so really we want to cast to a more specific interface than a real concrete impl,
- the specific impl/interface may not exist if it hasn't been built with the right `-tags`.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.