matrix-org / matrix-org/complement-crypto

Check usage of chromedp

Open
#107 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
18
Forks
12
Avg merge
2d 12h
Merged PRs (30d)
6

Description

I think each time we make a new JS client we're making a new _browser_, which is A) slow and B) prone to flakiness due to WS timeout errors. We should instead make them as new _tabs_, given each client is on a random high numbered port.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating where new JavaScript clients are created and where chromedp launches browsers. Trace whether each client gets a separate browser or can use a new tab, then inspect existing coverage for websocket timeout failures. Done means clients share a browser through separate tabs without the reported slowness or flakiness.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, javascript
Domain
testing-qa, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.