matrix-org / matrix-org/backend-meta
sign-off workflow doesn't ignore requirement for org members without write access
Open
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 1
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
See #9
> Shouldn't the check have exempted you as a member of the matrix-org org?
Nope, because GitHub's author_association is a bit rubbish. It doesn't appear to be org aware, but that's fine so long as you don't make a PR from a fork. I still need to figure out how to make this work for people who are in the org, but do not have write access.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the sign-off workflow and issue #9, then inspect how GitHub's author_association is used for membership checks. Done means the workflow correctly handles organization members without write access, while retaining the stated fork limitation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100