matplotlib / matplotlib/mplfinance

PNF return_calculated_values --> miny / maxy not correct

Open
#624 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
4.4k
Forks
678
PR merge metrics
No merged PRs in 30d

Description

I have noticed the miny / maxy might not be correct in the return_calculated_values of PNF (maybe in renko as well?)

The returned values:

miny 137.33999633789065
maxy 181.83999633789065

The chart:

pnf chart

Further, how is minx and maxx to be interpreted, as the x-achis is a timeline, but the values are decimal?
minx -0.9777777777777777
maxx 44.977777777777774

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the PNF return_calculated_values entry point and compare its miny/maxy values with the displayed chart. Check how minx/maxx are produced for the timeline, including whether Renko uses the same calculation; done means the returned bounds match the chart and their x-axis interpretation is documented or corrected.

Written by the indexing model from the issue text.

Assessment

Tech stack
matplotlib, python
Domain
data-visualization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.