matplotlib / matplotlib/mplfinance

PNF Box Dates & Renko reversal size

Open
#623 7 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
4.4k
Forks
678
PR merge metrics
No merged PRs in 30d

Description

First of all my big appreciation to Daniel and all other contributors for this great resource!

I have a request regarding the 'pnf' resp. 'renko' chart:

1) Is it possible to include to the return_calculated_values an additional array, that contains the dates for each box (e.g. pnf_box_date), that is matching the pnf_values? I guess it can be created easily in the same step when the pnf_values is processed.

2) I tried to get the dates from the renko return_calculated_values, but since there is no reversal size considered and therefore not equivalent to the 'pnf' chart, it was not possible. This would lead to my 2nd proposal to add reversal brick according to the 'pnf' logic.

Contributor guide

Open the contributing guide

Research direction

Locate the PNF and Renko calculation entry points that produce return_calculated_values and pnf_values. First trace how box or brick values are assembled, then verify that returned dates align with PNF values and that Renko reversal size follows the requested PNF logic. Done means both requested outputs are available and their alignment and reversal behavior are covered by checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
matplotlib, python
Domain
data-visualization
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.