matplotlib / matplotlib/mplfinance

Support for Legends

Open
#276 21 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
4.4k
Forks
678
PR merge metrics
No merged PRs in 30d

Description

Regarding [this](https://github.com/matplotlib/mplfinance/issues/274) question I posted 2 days ago, I started to inspect the code and made some changes. Now I'm able to do this:

`mpf.make_addplot(bars[["sma_10","sma_200"]],labels=["sma_10","sma_200"])`

Is this useful to the community? What other testing is needed and how do I submit the changes to see if they are approved?
Its the first time I change the code of a library I downloaded.

Hope you will find it useful. The results are in the image below.
![image](https://user-images.githubusercontent.com/61697701/96351527-3bd4bf00-1092-11eb-8419-4aedc4bea315.png)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with issue #274 and the shown make_addplot call to understand the requested legend behavior and existing API. Clarify the expected legend output and testing requirements from the discussion; done means the requested labels produce the agreed legend behavior and the relevant example is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-visualization
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.