matplotlib / matplotlib/mplfinance
Feature Request: vlines argument None or False or ...
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.4k
- Forks
- 678
- PR merge metrics
- No merged PRs in 30d
Description
Hello @DanielGoldfarb,
Mplfinance is looking great and I have adopted it in my Example Notebook for my Pandas TA Library.
Is your feature request related to a problem? Please describe.
Simple value to pass into vlines argument so it passes without error.
Describe the solution you'd like
Some value like None or False or whatever you deem appropriate for the package requirements.
Describe alternatives you've considered
I created an invisible out of chart range data to bypass the error. It's a hack but seems unnecessary.
if amat_sr:
vlines_ = dict(vlines=amat_sr, alpha=0.1, colors="
else:
# Hidden because vlines needs valid arguments even if None
vlines_ = dict(vlines=mpfdf.index[0], alpha=0, colors="white")
Additional context
I made a semi-dynamic Panels Chart Class Example Notebook for my Pandas TA Library. The plot method is located at the bottom of Input Cell 11. You can play around with the Chart class arguments in Input Cell 12.
Thanks for your time,
Kevin
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the plot method at the bottom of Input Cell 11 in the linked example notebook and reproduce the chart with vlines set to None or False. Trace the vlines argument handling in mplfinance, then verify that an omitted or empty value passes without error and that the notebook still renders the chart.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- matplotlib, python
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100