matplotlib / matplotlib/basemap
Test failures with pyshp 3.0.0 (AttributeError: 'tuple' object has no attribute 'tolist')
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 817
- Forks
- 395
- PR merge metrics
- No merged PRs in 30d
Description
As reported in Debian Bug #1110711, a few tests fail with pyshp 3.0.0:
Traceback (most recent call last):
File "/tmp/autopkgtest-lxc.j0rpiwrc/downtmp/autopkgtest_tmp/hurrtracks.py", line 17, in <module>
shp_info = m.readshapefile('huralll020','hurrtracks',drawbounds=False)
File "/usr/lib/python3/dist-packages/mpl_toolkits/basemap/__init__.py", line 2152, in readshapefile
bbox = shf.bbox.tolist()
^^^^^^^^^^^^^^^
AttributeError: 'tuple' object has no attribute 'tolist'
Full output: https://ci.debian.net/packages/b/basemap/unstable/amd64/62754867/
From the pyshp README:
- bbox, mbox and zbox attributes are all new Namedtuples.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in basemap/init.py at readshapefile, especially the line where shf.bbox.tolist() raises the error. Read pyshp 3.0.0's breaking-changes notes and reproduce the failure using the Debian report or the project's tests. Done means the affected tests pass with pyshp 3.0.0.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100