matomo-org / matomo-org/plugin-TrackingSpamPrevention

When banning an IP, delete the visit including all the actions

Open
#164 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
18
Forks
10
Avg merge
20h 11m
Merged PRs (30d)
1

Description

So far, when we ban an IP because of too many actions in one visit, we only block further tracking requests and optionally send an email.

However, the previously stored actions stay persisted in the DB. Can we instead delete them? As the visit was identified as spam we should also get rid of that information so the data stays more accurate.

We regularly get such visits with too many actions where it's clearly spam.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the IP-banning flow described in the issue and trace how the affected visit and its actions are persisted. Check the existing tracking-spam behavior and any related tests before changing it. Done means that a visit identified as spam is removed together with its previously stored actions, while the existing blocking and email behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, database
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.