matomo-org / matomo-org/plugin-LoginLdap
do not get all attributes in ldap_search calls
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- PHP
- Stars
- 37
- Forks
- 30
- Avg merge
- 22h 53m
- Merged PRs (30d)
- 19
Description
Relevant code to change is in Model\LdapUsers.php. Attributes depend on INI config, so cleanest solution is not obvious. Would be best to do when Dependency Injection is added to core.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Model\LdapUsers.php and review how its ldap_search calls obtain attributes from INI configuration. Check the project’s dependency-injection status before deciding on an approach. Done means searches request only the configured attributes rather than all attributes, with the behavior verified against the relevant LDAP configuration paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100