matomo-org / matomo-org/plugin-LoginLdap
Auth errors propagation
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 37
- Forks
- 30
- Avg merge
- 22h 53m
- Merged PRs (30d)
- 19
Description
During setting up of LoginLdap I used LDAP account test account. Everything was set correctly, however login was always failing with general information about bad username/pass. But the reason was different:
`DEBUG LoginLdap[2019-09-13 01:42:33 UTC] [aed33] /usr/local/www/matomo/plugins/UsersManager/UsersManager.php(210): This password is too weak, please supply another value or reset it.`
IMHO real reason should be propagated to login screen error message.
Matomo version: 3.11.0
LoginLdap version: 4.0.7
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with plugins/UsersManager/UsersManager.php at line 210, where the logged password-strength error appears, and trace how LoginLdap handles that failure before displaying the generic login message. Confirm the relevant error is propagated to the login screen instead of being replaced by the bad username/password message.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100