matomo-org / matomo-org/github-action-tests
Link to CI build artefacts doesn't work when source and target branch is the same
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 4
- Forks
- 8
- Avg merge
- 10d 6h
- Merged PRs (30d)
- 3
Description
It's not very common but can happen when community members don't use a new branch and open a PR from their fork within the same branch name.
Example PR — https://github.com/matomo-org/matomo/pull/20969
Target branch: 5.x-dev
Source branch: 5.x-dev
The link to the assets from UI tests is missing the branch as it probably evaluated there's no branch, and therefore the link doesn't present anything (goes to 404).
Stretch goal: When looking into this, we could also address branches with slashes in them to work as expected, which might be a configuration within the builds webserver. Alternatively we can replace slashes with some filesystem-indifferent character.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the missing UI-test artifact link with the example PR, where the source and target are both 5.x-dev. Trace how the CI build artifact URL is assembled and check how branch names are handled, including the stretch case of slashes. Done means the same-branch link resolves correctly, with branch names containing slashes addressed if feasible.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- ci-cd, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100