matomo-org / matomo-org/github-action-tests

pass token to actions/checkout for private submodules

Open
#14 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug triaged
Dominant language
Shell
Stars
4
Forks
8
Avg merge
10d 6h
Merged PRs (30d)
3

Description

Currently, if a plugin has a submodule that is a private repository, the generated github action will fail when trying to checkout the repository. This is due to the action trying to init/update submodules without a valid token.

This could be fixed by supplying a `token:` parameter to `actions/checkout` like so:

```
token: ${{ secrets.TESTS_ACCESS_TOKEN || secrets.GITHUB_TOKEN }}
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the generated GitHub Actions workflow and its actions/checkout step, then verify that the token is passed there and that a private submodule checkout succeeds without breaking the existing workflow.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.