matomo-org / matomo-org/github-action-tests
A child feature branch merging into its parent feature branch breaks plugin version checkout
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 4
- Forks
- 8
- Avg merge
- 10d 6h
- Merged PRs (30d)
- 3
Description
I'll leave this one here so we have it documented as a possible problem.
When a child feature branch is merging into its parent feature branch will cause the dependent plugin to checkout the latest version. In my case it causes 5.x to be checked out when its parent is based off 4.x. This causes some troubles with testing of course.
Recreation
- Create a feature branch
feature-abased off a4.x-devplugin branch. - Create another feature branch
feature-bbased offfeature-a - Run the tests for
feature-b
Actual: 5.x is checked out for the dependent plugins
Expected: 4.x version of the dependent plugin should be checked out.
Perhaps we can allow the base version to be defined so that this line will honor the intended Matomo version.
https://github.com/matomo-org/github-action-tests/blob/d52ff9fb5ef05c5e1d1d331866fd8b5c80f35f85/action.yml#L185
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at action.yml line 185 and trace how the dependent plugin version is selected when feature-b is based on feature-a. Reproduce the documented feature-a/feature-b scenario with a 4.x-dev parent and verify that the dependent plugin remains on 4.x rather than checking out 5.x.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, shell
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100