matomo-org / matomo-org/docker

difference in nginx template and docker template

Open
#344 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
1k
Forks
384
PR merge metrics
No merged PRs in 30d

Description

The `libs|vendor` location directive differes between the `nginx` template and the `docker` one:

```nginx
location ~ ^/(libs|vendor|plugins|misc|node_modules) {
deny all;
return 403;
}
```
source: https://github.com/matomo-org/matomo-nginx/blob/5b232af8ec1fd9d033f1c4ab9343f4073df64644/sites-available/matomo.conf#L80C11-L80C11

vs.

```nginx
location ~ /(libs|vendor|plugins|misc/user) {
deny all;
return 403;
}
```
source: https://github.com/matomo-org/docker/blob/7a87e915aae2d55168e90a76aea60f38122e28e5/.examples/nginx/matomo.conf#L58C1-L61C3

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare .examples/nginx/matomo.conf in this repository with the referenced sites-available/matomo.conf from matomo-org/matomo-nginx, focusing on the libs|vendor location directive. Determine the intended protected paths, make the templates consistent, and verify the resulting nginx configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, nginx
Domain
devops, infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.