matloff / matloff/polyreg

problem with maxInteractDeg

Open
#12 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
183
Forks
26
PR merge metrics
No merged PRs in 30d

Description

Hi,
I found the problem that, when the second tuning parameter changes (maxInteractDeg), the model estimated with the same "deg" remains unchanged.
In fact, from this example the design matrix remains unchanged.

`x <- iris[,1:4]`
`dim(getPoly(x, deg = 1, maxInteractDeg = 1)$xdata)`
`dim(getPoly(x, deg = 1, maxInteractDeg = 2)$xdata)`
`dim(getPoly(x, deg = 1, maxInteractDeg = 3)$xdata)`
`dim(getPoly(x, deg = 2, maxInteractDeg = 1)$xdata)`
`dim(getPoly(x, deg = 2, maxInteractDeg = 2)$xdata)`
`dim(getPoly(x, deg = 2, maxInteractDeg = 3)$xdata)`

What could this problem depend on?
Currently I do not find it useful to vary the model according to the degree of interaction.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the iris and getPoly expressions shown in the issue, then inspect the getPoly entry point to trace how deg and maxInteractDeg affect xdata. Done means the reproduced design-matrix dimensions change appropriately when maxInteractDeg changes, with the expected behavior documented or covered by the relevant package checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
machine-learning
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.