matloff / matloff/gitR

openShellEditor() returns 127 in Windows

Open
#3 0 comments 0 reactions 1 assignee View on GitHub

@franrivasortega is already working on this.

Since Aug 22, 2019.

bug
Dominant language
R
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Right now I'm at work and `Sys.getenv('EDITOR')` is returning "" in my session because the environment variable doesn't exist in Windows (at home I have Linux), this causes the command in `makeSysCmd()` return 127.

We should have this issue open to be aware that we need to adapt openShellEditor() for OS Win at some point, since is the most used OS.

Consider also the idea of using direct calls to `file.edit()` as a substitute for `openShellEditor()`, since it uses `getOption('editor')` to find out the default editor of the system.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.