matiasandina / matiasandina/uid_python_api
Document and optionally move train-envelope timing into Doric hardware sequencing
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 0
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
As of 2026-03-19, stimulation timing semantics need a clearer documented recommendation and a follow-up implementation decision.
Context
- The app currently uses Doric hardware for pulse shape (
period_ms,time_on_ms) but still enforces the train envelope (train.on_seconds,train.off_seconds) in Python timers. - Doric support clarified that the hardware-native mapping for a 20 Hz, 10 ms ON / 40 ms OFF pulse train with a 1 s ON / 3 s OFF envelope is:
period_ms = 50time_on_ms = 10nb_of_pulses_per_seq = 20delay_between_seq_ms = 3000nb_of_seq = 65535
- Doric also recommended validating sequence behavior in Doric Neuroscience Studio first, using the GUI signal preview before transferring settings into code via
ttlModulationand related DLL/API parameters.
Why this matters
- Sequence semantics are not obvious, especially for
nb_of_pulses_per_seq,delay_between_seq_ms,nb_of_seq, andGated + Restart. - Misunderstanding those fields can produce materially different stimulation behavior.
- If we want train envelopes to be hardware-timed, the controller should intentionally derive or honor those Doric sequence fields instead of relying on Python timers.
Current status
- Docs were updated locally to explain the timing split and to add a strong recommendation to validate waveform design in Doric Studio first.
- No runtime behavior was changed yet.
Follow-up questions
- Should
stimulus.train.*remain an app-level abstraction only, with explicitstimulus.square.*overrides for hardware-native sequencing? - Or should the controller derive Doric sequence parameters automatically from
stimulus.pulse.*+stimulus.train.*when the pattern is representable in hardware? - For closed-loop use, do we want hardware-native train envelopes by default, or only when a dedicated mode/flag is enabled?
Acceptance criteria
- Decide whether train OFF remains software-timed or moves to Doric-native sequencing.
- If moving to hardware, define the exact config contract and update
stim_controller.pyaccordingly. - Keep Doric Studio validation called out prominently in docs and operator workflow.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by validating the sequence behavior in Doric Neuroscience Studio using the GUI signal preview, then read stim_controller.py and the existing timing documentation. The work is done when the software-versus-hardware train-envelope decision is documented, the exact config contract is defined, and stim_controller.py is updated if hardware sequencing is chosen.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- embedded-iot
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100