mathoudebine / mathoudebine/turing-smart-screen-python
Sensor reading do not round values, they cut fractional part off instead.
Nobody has claimed this yet.
- Dominant language
- Rich Text Format
- Stars
- 2.3k
- Forks
- 412
- Avg merge
- 21h 10m
- Merged PRs (30d)
- 7
Description
Is your feature request related to a problem? If so, please describe the problem.
It's related to LibreHardwareMonitor library, which returns most of values with big granularity (fractional part). The current code "cuts" the fractional part of readed value (int(value)) instead of rounding it (round(value)). The result is that on 0.9% CPU usage Turing Smart Screen still displays 0% instead of rounding it up to 1%.
Describe the feature / solution to your problem you'd like
As I stated above, requesting dear @mathoudebine to use round(value) instead of int(value).
Describe alternatives you've considered / and or tested
None that come up to my mind.
Screenshots / photos & mockups of the Turing screen
none would help
Environment:
- Turing Smart Screen Python v. 3.9.3 master branch
- Windows 11, precisely LibreHardwareMonitorLib way of reading sensors (not sure if applies to python readings method)
- Python 3.13
- (not sure if matters) AMD Ryzen 5 5500 CPU, AMD Raden RX 6600 GPU
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name a file or test. Search the Python sensor-reading paths for the reported int(value) conversion, then check how values from LibreHardwareMonitor are displayed. Done means fractional readings are rounded, so a value such as 0.9% displays as 1% rather than 0%, with relevant tests updated or added if the project has coverage for this behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- observability-sre
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100