mathieudutour / mathieudutour/scroll-through-time

Failed to activate the scroll-through-time package

Open
#25 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
723
Forks
33
PR merge metrics
No merged PRs in 30d

Description

[Enter steps to reproduce:]

1. ...
2. ...

**Atom**: 1.55.0 x64
**Electron**: 6.1.12
**OS**: Microsoft Windows 10 Home
**Thrown From**: [scroll-through-time](https://github.com/mathieudutour/scroll-through-time) package 0.3.1

### Stack Trace

Failed to activate the scroll-through-time package

```
At file:///C:/Users/rdonn/.atom/packages/scroll-through-time/lib/scroll-through-time.js: Unterminated string constant (202:35)

SyntaxError: file:///C:/Users/rdonn/.atom/packages/scroll-through-time/lib/scroll-through-time.js: Unterminated string constant (202:35)

toggle(force) {
this.active = typeof force !== "getElementsByName('// DEBUG:new Promise(function(resolve, upgrade) {

});')" ? force : !this.active;
return this.active ? this.setupListener() : this.removeListener();
at Parser.pp.raise (/app.asar/node_modules/babylon/lib/parser/location.js:24:13)
at Parser.readString (/app.asar/node_modules/babylon/lib/tokenizer/index.js:703:49)
at Parser.getTokenFromCode (/app.asar/node_modules/babylon/lib/tokenizer/index.js:479:21)
at Parser.readToken (/app.asar/node_modules/babylon/lib/tokenizer/index.js:160:17)
at /app.asar/node_modules/babylon/lib/plugins/jsx/index.js:445:20)
at Parser.readToken (/app.asar/node_modules/babylon/lib/plugins/flow.js:775:22)
at Parser.nextToken (/app.asar/node_modules/babylon/lib/tokenizer/index.js:151:19)
at Parser.next (/app.asar/node_modules/babylon/lib/tokenizer/index.js:88:10)
at Parser.pp.parseExprOp (/app.asar/node_modules/babylon/lib/parser/expression.js:185:12)
at Parser.pp.parseExprOps (/app.asar/node_modules/babylon/lib/parser/expression.js:167:17)
at Parser.pp.parseMaybeConditional (/app.asar/node_modules/babylon/lib/parser/expression.js:145:19)
at Parser.pp.parseMaybeAssign (/app.asar/node_modules/babylon/lib/parser/expression.js:112:19)
at Parser.pp.parseMaybeAssign (/app.asar/node_modules/babylon/lib/parser/expression.js:132:23)
at Parser.pp.parseExpression (/app.asar/node_modules/babylon/lib/parser/expression.js:79:19)
at Parser.pp.parseStatement (/app.asar/node_modules/babylon/lib/parser/statement.js:137:23)
at Parser.parseStatement (/app.asar/node_modules/babylon/lib/plugins/flow.js:655:22)
at Parser.pp.parseBlock (/app.asar/node_modules/babylon/lib/parser/statement.js:442:21)
at Parser.pp.parseFunctionBody (/app.asar/node_modules/babylon/lib/parser/expression.js:747:22)
at Parser.parseFunctionBody (/app.asar/node_modules/babylon/lib/plugins/flow.js:643:20)
at Parser.pp.parseMethod (/app.asar/node_modules/babylon/lib/parser/expression.js:717:8)
at Parser.pp.parseObjPropValue (/app.asar/node_modules/babylon/lib/parser/expression.js:658:23)
at Parser.parseObjPropValue (/app.asar/node_modules/babylon/lib/plugins/flow.js:891:13)
at Parser.pp.parseObj (/app.asar/node_modules/babylon/lib/parser/expression.js:640:10)
at Parser.pp.parseExprAtom (/app.asar/node_modules/babylon/lib/parser/expression.js:392:19)
at Parser.parseExprAtom (/app.asar/node_modules/babylon/lib/plugins/jsx/index.js:412:22)
at Parser.pp.parseExprSubscripts (/app.asar/node_modules/babylon/lib/parser/expression.js:236:19)
at Parser.pp.parseMaybeUnary (/app.asar/node_modules/babylon/lib/parser/expression.js:217:19)
at Parser.pp.parseExprOps (/app.asar/node_modules/babylon/lib/parser/expression.js:163:19)
at Parser.pp.parseMaybeConditional (/app.asar/node_modules/babylon/lib/parser/expression.js:145:19)
at Parser.pp.parseMaybeAssign (/app.asar/node_modules/babylon/lib/parser/expression.js:112:19)
```

### Commands

```
```

### Non-Core Packages

```
Hydrogen 2.14.7
scroll-through-time 0.3.1
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open lib/scroll-through-time.js around line 202 and inspect the syntax reported by Atom's parser. Reproduce package activation in Atom 1.55.0 on Windows if possible, then verify that scroll-through-time activates without the reported unterminated-string error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
desktop
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.