mathieudutour / mathieudutour/github-tag-action
`feat!: some breaking change` format isn't working
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 733
- Forks
- 227
- PR merge metrics
- No merged PRs in 30d
Description
Spec number 13 from https://www.conventionalcommits.org/en/v1.0.0/:
> If included in the type/scope prefix, breaking changes MUST be indicated by a ! immediately before the :. If ! is used, BREAKING CHANGE: MAY be omitted from the footer section, and the commit description SHALL be used to describe the breaking change.
However, using `feat!` as a prefix, results in a PATCH release, not a MAJOR
Tried using a custom prefix mapping, but the expressions used to parse it seems to be dropping it due to the `!` and still resulted in a patch release.
I understand that this action is based off Angular's convention... so if you feel it's out of scope to make this change, I won't fight you :P
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start by tracing how commit prefixes are parsed and how the parsed type determines the SemVer bump, then reproduce the case with `feat!`. Done means a `feat!` prefix produces a major release rather than a patch release, with coverage for the documented format.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, typescript
- Domain
- ci-cd, release
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100