mathieudutour / mathieudutour/github-tag-action

'append_to_pre_release_tag' returns the branch name when provided an empty string

Open
#122 5 comments 12 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
733
Forks
227
PR merge metrics
No merged PRs in 30d

Description

I want to create a new tag, but have no suffix added by the action. However the use of the ternary operator in the action.ts code means that it interepts this empty string as not providing a value and instead uses the default of the branch name.

https://github.com/mathieudutour/github-tag-action/blob/master/src/action.ts#L65

Basically, we need some way to be able to provide an empty string if we want nothing appended

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/action.ts around line 65, where the append_to_pre_release_tag value is selected. Trace the tag-generation path and verify that an explicitly empty suffix is preserved rather than replaced by the branch name; done means the action can create a tag with no appended suffix.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, github-actions, typescript
Domain
ci-cd, release
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.