mathiasbynens / mathiasbynens/punycode.js
wrong mapDomain split
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 170
- PR merge metrics
- No merged PRs in 30d
Description
Since an email can contain multiple `@`, `mapDomain` function must find the last index of `@` to use it as the encoded chunk for the domain.
For example, this email is valid `"a@b"@c`: in that case the mail address is `"a@b"` and the domain is `c`.
Another more complex valid email:
`"very.(),:;<>[]\".VERY.\"@very@\\ \"very\".unusual"@mydomain.com`
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the mapDomain function and any tests covering email-like domain parsing. Check the supplied examples, including addresses with multiple @ characters; done means the domain is derived from the final @ while the preceding address remains intact, with regression coverage for these cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100