mathiasbynens / mathiasbynens/punycode.js

punycode(1.3.2) have AMD id('punycode'), which isn't comfortable when use requireJS.

Open
#88 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
170
PR merge metrics
No merged PRs in 30d

Description

Use the latest punycode, since punycode(1.3.2) export with:
define('punycode', function() { return punycode; });
which is portable when using requireJS.

For more detail, see https://github.com/browserify/browserify/pull/1865

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the package's AMD export and the browserify pull request linked in the issue. Compare version 1.3.2 with the latest punycode behavior under RequireJS; done means the module is portable for RequireJS as described and the relevant behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.