mathiasbynens / mathiasbynens/punycode.js

missing `es5` version breaks IE11

Open
#86 14 comments 18 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
170
PR merge metrics
No merged PRs in 30d

Description

Hallo Mathias,

while working on my Angular component library [eang](https://github.com/EAmode/eang) I realized that punycode@2.2.1 gets included into my build and since an `es5` version is missing, it is breaking IE11.

Not sure why it is needed in the bundle at all, but others seem to have similar issues: https://github.com/angular/angular/issues/21202#issuecomment-406817464

Would you consider a PR integrating Typescript to transpile to `es5` and `es6`?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the IE11 failure in the eang build and inspect how punycode@2.2.1 enters its bundle. Review the repository's current build setup and the linked Angular discussion for related context. Done means the package provides compatible es5 and es6 output without breaking its existing consumers.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
build-system, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.