mathiasbynens / mathiasbynens/punycode.js

What about ASCII characters not in [a-zA-Z0-9-] ?

Open
#73 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
170
PR merge metrics
No merged PRs in 30d

Description

The current implementation copies them as-is into the output, no matter whether they are allowed in domain names or not. Is that correct behavior?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating the path that copies non-[a-zA-Z0-9-] ASCII characters, then compare its behavior with the applicable domain-name rules in RFC 3492 and RFC 5891. Done means the expected handling is decided and covered by focused tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.