mathiasbynens / mathiasbynens/punycode.js

Any plans to support es6 import/export?

Open
#116 1 comment 7 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
170
PR merge metrics
No merged PRs in 30d

Description

I use this module in an Angular application and have a warning:

Warning: `filename.ts` depends on 'punycode'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

And I import using
import { toASCII } from 'punycode';

Do you have any plans to support es6 modules?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the module's current package and export setup, then check how its existing tests exercise imports. Reproduce the Angular CommonJS optimization warning described here and determine the expected ES6 import/export behavior. Done means the package supports that behavior without the reported warning and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, javascript
Domain
web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.