mathiasbynens / mathiasbynens/jsesc

detect and throw on cyclic references

Open
#55 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
800
Forks
54
PR merge metrics
No merged PRs in 30d

Description

For example:

```js
const cyclic = {};
cyclic.cyclic = cyclic;

// RangeError: Maximum call stack size exceeded
jsesc(cyclic);
```

I think this is typically done by tracking an array of seen values and pushing/popping when entering/exiting a recursive `jsesc` call. I might be able to implement if acceptable.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the cyclic object example through the jsesc entry point and inspect the recursive serialization path. The issue suggests tracking seen values while entering and exiting recursive calls; done means cyclic input produces an intentional error instead of a maximum call stack error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.