mathiasbynens / mathiasbynens/jsesc

Document or remove differences between `jsesc(data, { json: true })` and `JSON.stringify(data)`

Open
#17 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
800
Forks
54
PR merge metrics
No merged PRs in 30d

Description

For example, jsesc doesn’t skip `undefined` properties, and it doesn’t make use of `toJSON`:

``` js
var obj = {
'toJSON': function() {
return 'wat';
}
};

var x = {
'lol': obj
};

console.log([
JSON.stringify(x),
jsesc(x, { 'json': true })
]);
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation of the `json` option and compare its output with `JSON.stringify` for the `undefined`-property and `toJSON` examples in the issue. The issue names no files or tests; done means either documenting the intentional differences or aligning the behavior, with coverage for the demonstrated cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.