mathiasbynens / mathiasbynens/he

useNamedReferences doesn't work for all characters

Open
#74 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
3.6k
Forks
264
PR merge metrics
No merged PRs in 30d

Description

While setting `useNamedReferences` to `true` and `encodeEverything` to `true`, the character `/` is encoded as `/` but the character `\` is encoded as `\` The same happens with the hyphen/minus character, which is encoded as `-`

```
var entity = he.encode(html, {
useNamedReferences: true,
encodeEverything: true
})
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the shown he.encode options and the characters `/`, `\`, and `-`. Start by tracing the encoder path that handles useNamedReferences and encodeEverything; determine the intended named-reference behavior and add regression coverage so the reported inconsistency is resolved or explicitly documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.