mathiasbynens / mathiasbynens/he

Error when minimizing with Google closure-compiler

Open
#71 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.6k
Forks
264
PR merge metrics
No merged PRs in 30d

Description

https://github.com/google/closure-compiler
he.js: line 338, col 60, Expected an assignment or function call and instead saw an expression.
has(he, key) && (freeExports[key] = he[key]);

My guess would be something like this:

if (has(he, key)) {
freeExports[key] = he[key];
}

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at line 338 of he.js and reproduce the reported error with Google Closure Compiler. Confirm the completed change by running the compiler successfully against he.js without the assignment-or-function-call warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.