mathiasbynens / mathiasbynens/document.scrollingElement

Make frameset tests non-flaky

Open
#7 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
131
Forks
14
PR merge metrics
No merged PRs in 30d

Description

As @zcorpan says, maybe they’re flaky because the tests run before the `iframe` has loaded?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the frameset tests and inspect how they interact with the iframe load lifecycle. Run the tests repeatedly to reproduce the flakiness; done means the tests wait for the iframe to load and pass consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.