material-components / material-components/material-web
Add support for bottom-space and top-space tokens in md-list
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 11.3k
- Forks
- 1.1k
- Avg merge
- 20h 28m
- Merged PRs (30d)
- 13
Description
### Description
I would like to see `bottom-space` and `top-space` as supported tokens in `md-list`. At present there is no means to control the `padding-top` and `padding-bottom` of a list's `items` array. These values are set to `8px`. Adding `bottom-space` and `top-space` would allow modifying these values.
`bottom-space` and `top-space` are `$supported-tokens` in `md-menu`.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the md-list token definitions and compare them with the supported tokens in md-menu. Add support for bottom-space and top-space so they control list item padding-bottom and padding-top instead of the current 8px values; verify that both token values affect the rendered list spacing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scss
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100