material-components / material-components/material-web
Ripple of InputElements should be triggered by HTMLLabelElement
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 11.3k
- Forks
- 1.1k
- Avg merge
- 20h 28m
- Merged PRs (30d)
- 13
Description
### Description
According to the guidelines, or at least this gif:
https://m3.material.io/components/radio-button/guidelines#eba97636-1dd9-4e81-a1a6-20b8123d1b83
The radio's label, or any input's label, should trigger the ripple effect. This is also something that the vanilla radio does:
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/radio#try_it
Elements can also have multiple labels, so MdRipple.control should take in an array (or el | Array)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing MdRipple.control and how radio or other input components handle their HTMLLabelElement associations. Check the linked Material Design guidance and vanilla radio behavior, then verify that a label triggers the input ripple and that multiple labels are supported by the control API.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html, scss
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100