material-components / material-components/material-web
Closing dialog with "esc" does not remove scrim
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 11.3k
- Forks
- 1.1k
- Avg merge
- 20h 28m
- Merged PRs (30d)
- 13
Description
### What is affected?
Accessibility, Component
### Description
When I close a dialog by pressing the "esc" key the dialog closes but the scrim remains, which I wouldn't expect it to.
### Reproduction
https://stackblitz.com/edit/vitejs-vite-nzeagr?file=index.html
### Workaround
I guess you could query for the presence of the scrim onClose and delete it if you found it.
### Is this a regression?
No or unsure. This never worked, or I haven't tried before.
### Affected versions
Failing in v1.1.1 and v1.0.0
### Browser/OS/Node environment
Browser: Edge 120.0.2210.133
OS: Windows 11 10.0.22621
Node: v18.18.0
NPM: v10.2.3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked StackBlitz reproduction and inspect the dialog and scrim behavior when Escape closes the dialog. Trace the relevant Material Web component entry point and verify that the scrim is removed after closing with Escape, while preserving normal dialog closing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scss
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100