material-components / material-components/material-web
Dialog animation customization is not easy to extend
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 11.3k
- Forks
- 1.1k
- Avg merge
- 20h 28m
- Merged PRs (30d)
- 13
Description
What is affected?
Component
Description
If I am using 2 dialogs on my app and I modify dialog 1 Animations with myDialog.getOpenAnimation() dialog 2 gets modified as well, is there a workaround for it
Reproduction
https://stackblitz.com/edit/vitejs-vite-qsxwzz?file=index.html
Workaround
i didn't find any workaround
Affected versions
i only tried on version v1.1.1
Browser/OS/Node environment
Chrome Browser 120.0.6099.217 (Official Build) (64-bit) (cohort: Stable)
On my windows 11
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked StackBlitz reproduction in index.html and inspect how getOpenAnimation() behaves when two dialogs are used. Confirm that changing one dialog's animation does not affect the other, and document or test the independent behavior on version v1.1.1.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100