material-components / material-components/material-web

chip: default remove icon is different from 'close' icon

Open
#5,280 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SCSS
Stars
11.3k
Forks
1.1k
Avg merge
20h 28m
Merged PRs (30d)
13

Description

### What is affected?

Component

### Description

when `close` is used in `filter-chip` or `input-chip` to emulate the appearance of the default "remove" icon, the result is slightly different than the original.

Here's a capture:

![289800641-32df580a-461a-4666-82ee-009c08cca402](https://github.com/material-components/material-web/assets/2827383/f75cf455-4a8c-437a-9851-0a40894cc686)

(top: default, bottom: using `close` icon)

In other words the default icon is bigger than material symbols.

### Reproduction

see capture above

### Workaround

undefined

### Is this a regression?

No or unsure. This never worked, or I haven't tried before.

### Affected versions

v1.0.1

### Browser/OS/Node environment

everywhere

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the filter-chip and input-chip implementations for how their default remove icon differs from a close icon supplied through remove-trailing-icon. Use the linked capture and the described reproduction to verify that the default and supplied icons have matching sizing and appearance.

Written by the indexing model from the issue text.

Assessment

Tech stack
scss
Domain
design, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.