material-components / material-components/material-web
switch: checkmark icon has inaccessible color in some generated dark themes
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 11.3k
- Forks
- 1.1k
- Avg merge
- 20h 28m
- Merged PRs (30d)
- 13
Description
What is affected?
Component
Description
In dark mode and when theme color is too bright, the "selected" icon (when using icons on md-switch) will turn black making it hard to see while on dark color mode.
Reproduction
https://lit.dev/playground/#gist=9a466ce5a9dd7d7ca6900c0240e4d30b
Workaround
No workaround found.
Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
@material/web v1.0.1
Browser/OS/Node environment
Every brower/os.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Lit Playground reproduction and inspect the md-switch selected icon behavior when icons are enabled in generated dark themes with a bright theme color. Trace the switch styling for the selected checkmark and verify that the icon remains visible in dark mode and across the reported color condition.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scss
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100