material-components / material-components/material-web
Dialog closes when dragging click outside of it
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 11.3k
- Forks
- 1.1k
- Avg merge
- 20h 28m
- Merged PRs (30d)
- 13
Description
Dialog listens to the mouse out event (understandable) but should add a way to prevent it closes when selecting text like in an input field
Probably best to check if the click started in the dialog
Originally posted by @VandeurenGlenn in https://github.com/material-components/material-web/issues/4756#issuecomment-1690548111
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the dialog interaction shown in the issue and trace the Dialog mouse-out handling described there. Check how a drag that begins inside the dialog is treated, then verify that selecting text in an input no longer closes the dialog while clicks that start outside still do.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100