material-components / material-components/material-components-android

[Bottom Sheet] Weird animation when dismissing modal Bottom Sheet with back button/gesture on 1.10.0

Open
#4,106 1 comment 0 reactions 1 assignee View on GitHub

@afohrman is already working on this.

Since Mar 19, 2024.

bug Widget: BottomSheet
Dominant language
Java
Stars
17.4k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

Hi, there is weird animation artifact introduced on 1.10.0. I think it is related to adding predictive back press.

It only happens if you use back button or gesture to dismiss. Dismissing when tapped outside is not affected. As you can see, on 1.10.0 there is some sort of artifact as it is disappearing. Animation seems to stop and repeat a bit just as about to finish.

Video from 1.9.0

https://github.com/material-components/material-components-android/assets/14060247/58c7aa57-e050-49ec-9588-512cda05dc66

Video from 1.10.0

https://github.com/material-components/material-components-android/assets/14060247/b27e19d4-becb-45cf-b9c3-fbf30e0927f1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.