material-components / material-components/material-components-android

[Side Sheet] Inconsistent behavior when dismissing the dialog

Open
#3,609 2 comments 0 reactions 1 assignee View on GitHub

@FooIbar is already working on this.

Since Sep 27, 2023.

bug Widget: SideSheet
Dominant language
Java
Stars
17.4k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

In the [doc](https://github.com/material-components/material-components-android/blob/master/docs/components/SideSheet.md#modal-side-sheet-example):

> You can then show the side sheet with `sideSheetDialog.show()` and dismiss it with `sideSheetDialog.hide()`. `SideSheetDialog` has built in functionality to automatically cancel the dialog after it is swiped off the screen.

In the latter case, it will call `cancel()`, which calls `dismiss()`, resulting in different behavior than `hide()`.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.